transpile: Factor out more pointer-related functions#1521
Open
Rua wants to merge 4 commits intoimmunant:masterfrom
Open
transpile: Factor out more pointer-related functions#1521Rua wants to merge 4 commits intoimmunant:masterfrom
Rua wants to merge 4 commits intoimmunant:masterfrom
Conversation
Rua
force-pushed
the
pointer-casts
branch
2 times, most recently
from
ff423e5 to
3a55413
Compare
kkysen
reviewed
Jan 19, 2026
Contributor
kkysen
left a comment
kkysen
left a comment
There was a problem hiding this comment.
By the way, when you do refactoring PRs like this, can you try to split out the pure moves vs. the semantic changes more carefully/fine-grained? It makes it much harder to review when mostly moves are mixed with some other changes (although I'm not sure if there are better ways of viewing the diffs; I tried --color-moved but it doesn't really work usually).
Contributor
Author
How is this now? |
Contributor
Author
|
Does anything else need to be done here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This factors out functions for two things: casts involving pointers, and null checking. In the case of
==and!=operators in a non-conditional context (in operators.rs), this also adds special handling for regular pointers, where only function pointers were specially handled previously. This means thatis now translated with the
is_nullmethod as well, instead of with the==operator andcore::ptr::null.